Check for trailing characters when parsing std::string. #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library, kazuho! This issue came up in my work recently, and I thought I'd offer a patch to address what seems to me to be erroneous behavior:
When parsing a stream, it makes sense to return successfully if a valid JSON value is streamed in, regardless of what comes afterward. When parsing a
std::string
, however, I think it's appropriate to return an error if any non-whitespace trailing characters are detected. In the case ofparse(value, std::string)
, it only makes sense for the input string to contain a single valid JSON value, and comprehensive error checking should catch if this is not the case. This patch checks for such trailing characters and returns an error if they are present. Thoughts?