Fix example to not report syntax error on valid JSON input #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great to pull at least commit f5fdb1f Thank you. |
Adds parse_array_stop(size_t) override which returns true to the root_context class in the streaming.cc example. If not overriden, picojson::deny_parse_context::parse_array_stop(size_t) returns false what causes syntax error. Related issue: kazuho#82
Used in the example std::istream_iterator skips whitespace and thus
a parser can produce unexpected reult, e.g.:
Input: [{"x":"test space","y":20}]
Output: "testspace",20
std::istreambuf_iterator does not skip whitespace, so is more
appropriate:
Output: "test space",20
More info:
http://en.cppreference.com/w/cpp/iterator/istream_iterator (see "Notes"
section).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
parse_array_stop(size_t)override, which returnstrue, tothe
root_contextclass in thestreaming.ccexample.If not overriden,
picojson::deny_parse_context::parse_array_stop(size_t)returns
falsewhat causes syntax error.Related issue: #82