-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPipes debug api #149
base: main
Are you sure you want to change the base?
SPipes debug api #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will go over all of it after my comments are resolved.
@@ -182,7 +182,7 @@ private void persistPipelineExecutionFinished(final EntityManager em, final long | |||
em.find(Transformation.class, pipelineExecutionIri, pd); | |||
|
|||
// new | |||
Date startDate = (Date) getSingletonPropertyValue(pipelineExecution, SPIPES.has_pipeline_execution_start_date); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is rationale behind this change ?
s-pipes-debug/src/main/java/cz/cvut/spipes/debug/config/DispatcherServletInitializer.java
Outdated
Show resolved
Hide resolved
s-pipes-debug/src/main/java/cz/cvut/spipes/debug/config/DispatcherServletInitializer.java
Outdated
Show resolved
Hide resolved
s-pipes-debug/src/main/java/cz/cvut/spipes/debug/model/ModuleExecution.java
Outdated
Show resolved
Hide resolved
s-pipes-model/src/main/java/cz/cvut/spipes/model/Transformation.java
Outdated
Show resolved
Hide resolved
s-pipes-model/src/main/java/cz/cvut/spipes/model/Transformation.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the review incrementally.
No description provided.