Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPipes debug api #149

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

SPipes debug api #149

wants to merge 56 commits into from

Conversation

mircheqtm
Copy link

No description provided.

@blcham blcham self-requested a review February 23, 2023 13:59
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go over all of it after my comments are resolved.

doc/examples/hello-world/config.ttl Outdated Show resolved Hide resolved
doc/examples/skosify/module-execution/config.ttl Outdated Show resolved Hide resolved
@@ -182,7 +182,7 @@ private void persistPipelineExecutionFinished(final EntityManager em, final long
em.find(Transformation.class, pipelineExecutionIri, pd);

// new
Date startDate = (Date) getSingletonPropertyValue(pipelineExecution, SPIPES.has_pipeline_execution_start_date);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is rationale behind this change ?

s-pipes-core/src/main/resources/config-core.properties Outdated Show resolved Hide resolved
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the review incrementally.

docker-compose.yaml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
s-pipes-model/src/main/java/cz/cvut/spipes/Vocabulary.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants