Fix FakerPHP#759 : The output of the

md5(), sha1() and sha256() generators is misleading
kcassam · Apr 2, 2024 · 8834477 · 8834477
1 parent 2114cc6
commit 8834477
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Provider/Miscellaneous.php b/src/Provider/Miscellaneous.php
@@ -249,7 +249,7 @@ public static function boolean($chanceOfGettingTrue = 50)
      */
     public static function md5()
     {
-        return md5(self::numberBetween());
+        return md5(random_bytes(16));
     }
 
     /**
@@ -259,7 +259,7 @@ public static function md5()
      */
     public static function sha1()
     {
-        return sha1(self::numberBetween());
+        return sha1(random_bytes(20));
     }
 
     /**
@@ -269,7 +269,7 @@ public static function sha1()
      */
     public static function sha256()
     {
-        return hash('sha256', self::numberBetween());
+        return hash('sha256', random_bytes(32));
     }
 
     /**