fix optional attr

Signed-off-by: he1pa <[email protected]>
kcl-lang · Jan 14, 2025 · 0746bb3 · 0746bb3
1 parent ba7b6a6
commit 0746bb3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/kclvm/evaluator/src/schema.rs b/kclvm/evaluator/src/schema.rs
@@ -206,11 +206,11 @@ impl SchemaEvalContext {
     }
 
     /// Get all attribute from schema
-    pub fn get_attrs(s: &Evaluator, ctx: &SchemaEvalContextRef) -> Vec<String> {
+    pub fn get_attrs(s: &Evaluator, ctx: &SchemaEvalContextRef) -> Vec<(String, bool)> {
         let mut attrs = vec![];
         for stmt in &ctx.borrow().node.body {
             if let ast::Stmt::SchemaAttr(attr) = &stmt.node {
-                attrs.push(attr.name.node.clone());
+                attrs.push((attr.name.node.clone(), attr.is_optional));
             }
         }
         if let Some(index) = ctx.borrow().parent {

diff --git a/kclvm/evaluator/src/ty.rs b/kclvm/evaluator/src/ty.rs
@@ -124,8 +124,9 @@ pub fn type_pack_and_check(
                                 }
                             }
 
-                            for attr in SchemaEvalContext::get_attrs(s, &caller.ctx) {
-                                if !config.values.contains_key(&attr) {
+                            for (attr, is_optional) in SchemaEvalContext::get_attrs(s, &caller.ctx)
+                            {
+                                if !config.values.contains_key(&attr) && !is_optional {
                                     error_msgs
                                         .push(format!("Schema {}'s attr {} is missing", tpe, attr));
                                 }