perform: Parser performance optimization: remove duplicate dependency…

… analysis Signed-off-by: he1pa <[email protected]>
kcl-lang · Oct 23, 2024 · d79d9a1 · d79d9a1
1 parent fc64537
commit d79d9a1
Showing 1 changed file with 10 additions and 29 deletions.
diff --git a/kclvm/parser/src/lib.rs b/kclvm/parser/src/lib.rs
@@ -816,19 +816,7 @@ pub fn parse_entry(
         let module_cache_read = module_cache.read();
         match &module_cache_read {
             Ok(m_cache) => match m_cache.ast_cache.get(&file.canonicalize()) {
-                Some(m) => {
-                    let deps = get_deps(&file, m.as_ref(), pkgs, pkgmap, opts, sess.clone())?;
-                    match &mut file_graph.write() {
-                        Ok(file_graph) => {
-                            file_graph.update_file(&file, &deps);
-                            if file_graph.toposort().is_ok() {
-                                unparsed_file.extend(deps);
-                            }
-                            continue;
-                        }
-                        Err(e) => return Err(anyhow::anyhow!("Parse entry failed: {e}")),
-                    }
-                }
+                Some(_) => continue,
                 None => {
                     drop(module_cache_read);
                     let deps = parse_file(
@@ -921,27 +909,20 @@ pub fn parse_program(
         };
 
         let pkg = pkgmap.get(file).expect("file not in pkgmap");
+        fix_rel_import_path_with_file(
+            &pkg.pkg_root,
+            &mut m,
+            file,
+            &pkgmap,
+            opts.clone(),
+            sess.clone(),
+        );
+
         match pkgs.get_mut(&file.pkg_path) {
             Some(modules) => {
-                fix_rel_import_path_with_file(
-                    &pkg.pkg_root,
-                    &mut m,
-                    file,
-                    &pkgmap,
-                    opts.clone(),
-                    sess.clone(),
-                );
                 modules.push(m);
             }
             None => {
-                fix_rel_import_path_with_file(
-                    &pkg.pkg_root,
-                    &mut m,
-                    file,
-                    &pkgmap,
-                    opts.clone(),
-                    sess.clone(),
-                );
                 pkgs.insert(file.pkg_path.clone(), vec![m]);
             }
         }