Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type upgrade for the assign stmt type annotation for the call expression #1679

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1674

fix: type upgrade for the assign stmt type annotation for the call expression

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11269298183

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.006%) to 70.651%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.06%
kclvm/tools/src/LSP/src/compile.rs 1 83.5%
kclvm/sema/src/core/symbol.rs 3 53.63%
kclvm/driver/src/toolchain.rs 4 88.89%
Totals Coverage Status
Change from base Build 11247800898: -0.006%
Covered Lines: 51444
Relevant Lines: 72814

💛 - Coveralls

@Peefy Peefy merged commit 5d95a09 into kcl-lang:main Oct 10, 2024
13 checks passed
@Peefy Peefy deleted the fix-upgrade-ty-for-non-schema-ty branch October 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: lambda expression return value type error
3 participants