Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows ci #1685

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Fix windows ci #1685

merged 4 commits into from
Oct 12, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11304140514

Details

  • 289 of 305 (94.75%) changed or added relevant lines in 13 files are covered.
  • 17 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 70.554%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast/src/ast.rs 12 14 85.71%
kclvm/tools/src/LSP/src/rename.rs 33 35 94.29%
kclvm/tools/src/LSP/src/tests.rs 165 167 98.8%
kclvm/tools/src/LSP/src/document_symbol.rs 26 29 89.66%
kclvm/tools/src/LSP/src/goto_def.rs 22 29 75.86%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.06%
kclvm/tools/src/LSP/src/document_symbol.rs 1 86.72%
kclvm/tools/src/LSP/src/inlay_hints.rs 3 92.31%
kclvm/tools/src/LSP/src/state.rs 12 82.73%
Totals Coverage Status
Change from base Build 11303629540: 0.04%
Covered Lines: 51596
Relevant Lines: 73130

💛 - Coveralls

Signed-off-by: he1pa <[email protected]>
@He1pa He1pa force-pushed the fix_windows_ci branch 4 times, most recently from 369f582 to 5b389bc Compare October 12, 2024 07:47
Signed-off-by: he1pa <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa changed the title [wip] Fix windows ci Fix windows ci Oct 12, 2024
@Peefy Peefy merged commit a36e4d7 into kcl-lang:main Oct 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants