Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support functions for filesha512 and BLAKE-3 hashing. #1697

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

slashexx
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Feat: #1664

2. What is the scope of this PR (e.g. component or file name):

kclvm/runtime/src/crypto/mod.rs

3. Provide a description of the PR (e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

This PR introduces two new functions for hashing files: filesha512 and fileblake3. These functions allow users to compute the SHA-512 and BLAKE3 hashes of a specified file, respectively. The functionality enhances KCL's cryptographic capabilities, allowing for better data integrity verification. More details: [link to relevant documentation if available].

4. Are there any breaking changes?(Y/N) and describe the breaking changes (e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Currently, I have not added tests for these changes. I plan to implement tests to ensure the correctness of the new hashing functions.

@Peefy
Copy link
Contributor

Peefy commented Oct 17, 2024

@slashexx CI failed. Could you please format the Rust code?

@slashexx
Copy link
Contributor Author

slashexx commented Oct 17, 2024

Apologies for my oversight.

I've formatted the file.

@coveralls
Copy link
Collaborator

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11379971838

Details

  • 0 of 57 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 70.49%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/crypto/mod.rs 0 57 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/tests.rs 1 98.58%
kclvm/tools/src/LSP/src/inlay_hints.rs 3 92.31%
Totals Coverage Status
Change from base Build 11363027822: -0.05%
Covered Lines: 51586
Relevant Lines: 73182

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM.

@Peefy Peefy merged commit f328749 into kcl-lang:main Oct 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants