Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed OverrideFile insert unification position error #1702

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

closed #1701

2. What is the scope of this PR (e.g. component or file name):

OverrideFile API

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe requested a review from Peefy October 21, 2024 03:41
@zong-zhe zong-zhe self-assigned this Oct 21, 2024
@zong-zhe zong-zhe added the bug Something isn't working label Oct 21, 2024
@zong-zhe zong-zhe added this to the v0.11.0 Release milestone Oct 21, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit f298eeb into kcl-lang:main Oct 21, 2024
12 of 13 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11432766130

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 32 of 45 (71.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 70.505%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/override.rs 30 43 69.77%
Totals Coverage Status
Change from base Build 11431725688: 0.04%
Covered Lines: 51721
Relevant Lines: 73358

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: the location of the configuration block inserted by the OverrideFile is incorrect
3 participants