-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ POC for mounts (Master PR, not for merging) #3190
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
b7704c2
to
597e01c
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR is a working example of workspace mounts mounting remote cluster on top of it.
contrib
directory in the long term will go to the separate repository (We can keep it here if people agree too).In addition this enables core to run with bit more flexible mini-front-proxy, as I found very hard to develop external VirtualWorskapces using
kcp start
so kinda took it and extended.This add example of following:
where:
root:providers:mounts
is where all APIExports lives and where code operators are looking at.root:operators:mounts
is where people operators created their bindings and created TARGET cluster objects (separate binding)root:consumers
where consumer bounded MOUNT apiexport and created a single mount wskind-cluster
with mount backed by Target API.In addition when bootstrapping shard-aware operators - it's painful and hard to make miskates. I did some skeleton but I think we need a framework for this.
In general this this WIP PR, to be split to many many smalls ones.
✔️ #3188 Fix regression when generating deep copy
✔️ #3183 Add workspace phase update logic
✔️ #3199 enable dev mode
🖊️ #3231 Fix small bug added in 3199
Related issue(s)
#3189 as follow-up
Release Notes