Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ POC for mounts (Master PR, not for merging) #3190

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Oct 27, 2024

Summary

This PR is a working example of workspace mounts mounting remote cluster on top of it.

  • In general everything in contrib directory in the long term will go to the separate repository (We can keep it here if people agree too).
  • Any code in core would need to be split and merged as smaller prs.

In addition this enables core to run with bit more flexible mini-front-proxy, as I found very hard to develop external VirtualWorskapces using kcp start so kinda took it and extended.

This add example of following:

mjudeikis@unknown2:/go/src/github.com/kcp-dev/kcp/contrib/mounts-vw$ k ws tree
.
└── root
    ├── consumer
    │   └── kind-cluster
    ├── operators
    │   └── mounts
    └── providers
        └── mounts

where:
root:providers:mounts is where all APIExports lives and where code operators are looking at.
root:operators:mounts is where people operators created their bindings and created TARGET cluster objects (separate binding)
root:consumers where consumer bounded MOUNT apiexport and created a single mount ws kind-cluster with mount backed by Target API.

In addition when bootstrapping shard-aware operators - it's painful and hard to make miskates. I did some skeleton but I think we need a framework for this.

In general this this WIP PR, to be split to many many smalls ones.

✔️ #3188 Fix regression when generating deep copy
✔️ #3183 Add workspace phase update logic
✔️ #3199 enable dev mode
🖊️ #3231 Fix small bug added in 3199

Related issue(s)

#3189 as follow-up

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 27, 2024
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 27, 2024
@mjudeikis mjudeikis changed the title sparkles: POC for mounts (Master PR, not for merging) ✨ POC for mounts (Master PR, not for merging) Oct 27, 2024
@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2024
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2024
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mjudeikis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants