Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JSON, you can explicitly define a value as
undefined
:When running the
format
function against the above object, the following error is observed:This commit adds the missing safeguard against any explicit undefined values which prevents the fall through to
throw new Error('can't format ${typeof value}')
.Adding this surfaces a small issue wherein\n\n
is written to the formatted string. As far as I can tell, this is due to the way the${eol}
is prepended (rather than appended) to each line. There is a.replace
method call to take care of the\n\n
, however, this has a limit. For example,\n\n\n
would still become\n\n
.Even accounting for the above double-line issue, this does fix the fatal error when dealing withundefined
values and still produces a valid Lua string.Edit: I solved the above with a simple
do...while
loop.A specific test case was added because the shape of the JSON and Lua are not interchangeable. For example: