-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: move node_modules out of edx-platform repo #18
Commits on Jan 17, 2023
-
ci: better github release management with scriv
In scriv 1.1.0 the GitHub release description can be templated: nedbat/scriv#61 https://github.com/nedbat/scriv/releases/tag/1.1.0 This means that we can finally get rid of our ugly scripts to generate the release description \o/
Configuration menu - View commit details
-
Copy full SHA for 8f2df6a - Browse repository at this point
Copy the full SHA 8f2df6aView commit details -
Merge remote-tracking branch 'origin/master' into nightly
Overhang.IO committedJan 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 9b22498 - Browse repository at this point
Copy the full SHA 9b22498View commit details
Commits on Jan 18, 2023
-
refactor: annotation with __future__.annotations
Adds `from __future__ import annotations` to the top of every module, right below the module's docstring. Replaces any usages of t.List, t.Dict, t.Set, t.Tuple, and t.Type with their built-in equivalents: list, dict, set, tuple, and type. Ensures that make test still passes under Python 3.7, 3.8 and 3.9.
Configuration menu - View commit details
-
Copy full SHA for 4da32ab - Browse repository at this point
Copy the full SHA 4da32abView commit details -
fix: 'example.com' links in registration emails
When a user registers, they receive a confirmation email. This email contained two links to "https://example.com/..." urls. This was caused by the fact that the default site, indicated by SITE_ID=1, was example.com. We resolve this issue by setting instead SITE_ID=2, which should point to the site with the LMS domain name. This is a potentially breaking change for platforms that have manually set to 1 the id of the LMS site in the database. These platforms should now set SITE_ID=1 via a plugin. Alternatives we have considered include modifying the id field of the LMS site in the database. Unfortunately such a change would have important consequences, as the site ID is used as a foreign key for other models. Note that non-https sites still include https links in the registration emails. This is because the "https" scheme is hardcoded by the "ensure_url_is_absolute" utility function. So there is nothing we can do about this without making changes upstream. Close overhangio#572.
Configuration menu - View commit details
-
Copy full SHA for 56a7614 - Browse repository at this point
Copy the full SHA 56a7614View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca04b24 - Browse repository at this point
Copy the full SHA ca04b24View commit details -
fix: get rid of lms/cms
CORS_ORIGIN_WHITELIST
warningsThe LMS and CMS were producing lots of logs similar to: cms_1 | 2023-01-17 15:30:11,359 INFO 7 [openedx.core.djangoapps.cors_csrf.helpers] [user 7] [ip 31.223.46.44] helpers.py:64 - Origin 'https://studio.demo.openedx.overhang.io' was not in `CORS_ORIGIN_WHITELIST`; full referer was 'https://studio.demo.openedx.overhang.io/learning/course/course-v1:edX+DemoX+Demo_Course/home' and requested host was 'studio.demo.openedx.overhang.io'; CORS_ORIGIN_ALLOW_ALL=False These warnings are produced by openedx.core.djangoapps.cors_csrf.helpers. I don't think they indicate any problem, but they pollute the logs. They are resolved by adding the "http(s)://<lms/cms host>" to CORS_ORIGIN_WHITELIST in production, so we did just that.
Configuration menu - View commit details
-
Copy full SHA for d629ca9 - Browse repository at this point
Copy the full SHA d629ca9View commit details -
refactor: annotation with __future__.annotations
Adds `from __future__ import annotations` to the top of every module, right below the module's docstring. Replaces any usages of t.List, t.Dict, t.Set, t.Tuple, and t.Type with their built-in equivalents: list, dict, set, tuple, and type. Ensures that make test still passes under Python 3.7, 3.8 and 3.9.
Configuration menu - View commit details
-
Copy full SHA for ac1a875 - Browse repository at this point
Copy the full SHA ac1a875View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f67506 - Browse repository at this point
Copy the full SHA 0f67506View commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4fe5fcf - Browse repository at this point
Copy the full SHA 4fe5fcfView commit details -
Merge remote-tracking branch 'origin/master' into nightly
Overhang.IO committedJan 19, 2023 Configuration menu - View commit details
-
Copy full SHA for cad1e03 - Browse repository at this point
Copy the full SHA cad1e03View commit details
Commits on Jan 20, 2023
-
perf: move node_modules out of edx-platform repo
Background: NPM packages were installed into the openedx image at /openedx/edx-platform/node_modules. So, when one mounted their own copy of edx-platform, the built-in node_modules folder was overriden. This forced edx-platform developers to re-run ``npm install``, which is redundant, slow, resource-intensive, and added complexity to the first-time developer setup process. If one forgot to run ``npm install``, their LMS/CMS frontend would be broken. And, when edx-platform's NPM requirements were updated, developers would not receive these updates from the openedx image; they would need to think to re-run ``npm install`` themselves. The solution: Move /openedx/edx-platform/node_modules to /openedx/node_modules. Note that this new location is outside of the edx-platform repository. So, when a developer mounts their own copy of edx-platform, the image's node_modules will remain intact. Closes openedx-unsupported/wg-developer-experience#150
Configuration menu - View commit details
-
Copy full SHA for 9cff095 - Browse repository at this point
Copy the full SHA 9cff095View commit details