Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing PDB for http addon interceptors #658

Closed
abatilo opened this issue Jun 30, 2024 · 2 comments · Fixed by #662
Closed

Missing PDB for http addon interceptors #658

abatilo opened this issue Jun 30, 2024 · 2 comments · Fixed by #662

Comments

@abatilo
Copy link
Contributor

abatilo commented Jun 30, 2024

There is no pod disruption budget on the http addon interceptors, which means that during node rollover, there might not be any interceptors available to add requests to its queue. Since the queues themselves are in memory, that means that there would be dropped requests.

Could we add a PDB to that replicaset?
@zroubalik
Copy link
Member

@abatilo are you willing to contribute this?

@abatilo abatilo mentioned this issue Jul 14, 2024
Merged
abatilo added a commit to abatilo/charts-1 that referenced this issue Jul 14, 2024
@abatilo
Add a pdb template for the http-add-on interceptor
1d6c23d 
There is no pod disruption budget on the http addon interceptors, which
means that during node rollover, there might not be any interceptors
available to add requests to its queue. Since the queues themselves are
in memory, that means that there would be dropped requests.

Closes kedacore#658
abatilo added a commit to abatilo/charts-1 that referenced this issue Jul 14, 2024
@abatilo
Add a pdb template for the http-add-on interceptor
1467b04 
There is no pod disruption budget on the http addon interceptors, which
means that during node rollover, there might not be any interceptors
available to add requests to its queue. Since the queues themselves are
in memory, that means that there would be dropped requests.

Closes kedacore#658

Signed-off-by: Aaron Batilo <[email protected]>
@abatilo
Copy link
Contributor Author

abatilo commented Jul 14, 2024

Hi @zroubalik! I am willing to contribute this!

#662

abatilo added a commit to abatilo/charts-1 that referenced this issue Jul 15, 2024
@abatilo
Add a pdb template for the http-add-on interceptor
73e59d0 
There is no pod disruption budget on the http addon interceptors, which
means that during node rollover, there might not be any interceptors
available to add requests to its queue. Since the queues themselves are
in memory, that means that there would be dropped requests.

Closes kedacore#658

Signed-off-by: Aaron Batilo <[email protected]>
abatilo added a commit to abatilo/charts-1 that referenced this issue Jul 16, 2024
@abatilo
Add a pdb template for the http-add-on interceptor
a9d43bc 
There is no pod disruption budget on the http addon interceptors, which
means that during node rollover, there might not be any interceptors
available to add requests to its queue. Since the queues themselves are
in memory, that means that there would be dropped requests.

Closes kedacore#658

Signed-off-by: Aaron Batilo <[email protected]>
wozniakjan pushed a commit that referenced this issue Sep 25, 2024
@abatilo @wozniakjan
Add a pdb template for the http-add-on interceptor (#662)
a563cad 
There is no pod disruption budget on the http addon interceptors, which
means that during node rollover, there might not be any interceptors
available to add requests to its queue. Since the queues themselves are
in memory, that means that there would be dropped requests.

Closes #658

Signed-off-by: Aaron Batilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a pdb template for the http-add-on interceptor abatilo/charts-1
2 participants
@zroubalik @abatilo