Add a pdb template for the http-add-on interceptor #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abatilo
force-pushed
the
abatilo/interceptor-pdb
branch
from
1d6c23d
to
1467b04
Compare
tomkerkhove
reviewed
Jul 15, 2024
abatilo
force-pushed
the
abatilo/interceptor-pdb
branch
from
1467b04
to
73e59d0
Compare
|
Changes made. Please take a look when you can @tomkerkhove |
tomkerkhove
approved these changes
Jul 16, 2024
There is no pod disruption budget on the http addon interceptors, which means that during node rollover, there might not be any interceptors available to add requests to its queue. Since the queues themselves are in memory, that means that there would be dropped requests. Closes kedacore#658 Signed-off-by: Aaron Batilo <[email protected]>
abatilo
force-pushed
the
abatilo/interceptor-pdb
branch
from
73e59d0
to
a9d43bc
Compare
zroubalik
approved these changes
Aug 7, 2024
JorTurFer
approved these changes
Sep 2, 2024
wozniakjan
pushed a commit
that referenced
this pull request
Sep 25, 2024
There is no pod disruption budget on the http addon interceptors, which means that during node rollover, there might not be any interceptors available to add requests to its queue. Since the queues themselves are in memory, that means that there would be dropped requests. Closes #658 Signed-off-by: Aaron Batilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no pod disruption budget on the http addon interceptors, which
means that during node rollover, there might not be any interceptors
available to add requests to its queue. Since the queues themselves are
in memory, that means that there would be dropped requests.
Closes #658