Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Annotations are not handled correctly #482

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Jun 23, 2023

Annotations are optional but enforced

  • additionalAnnotations are optional but enforced
  • additionalAnnotations & service.additionalAnnotations are not rendered correctly wrt whitespace
  • toYaml drops quoting
  • additionalAnnotations & service.additionalAnnotations was not supported in webhooks
  • CI did not use these annotations during tests

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #481

@tomkerkhove tomkerkhove requested a review from a team as a code owner June 23, 2023 06:29
@tomkerkhove
Copy link
Member Author

Testing input:

nodeSelector:
  some/node.selector: 'true'
podIdentity:
  azureWorkload:
    clientId: ''
    enabled: true
prometheus:
  metricServer:
    enabled: true
  operator:
    enabled: true
    port: 8080
  webhooks:
    enabled: true
additionalAnnotations:
  sample: "annotation"
service:
  annotations:
    hello: "world yall"

Output

$ helm install keda --values D:\Code\sandbox\keda-sandbox\values.yml --dry-run --generate-name
NOTES:
=====================================================================================
KEDA - Kubernetes Event Driven Autoscaling
=====================================================================================
Get started by deploying Scaled Objects to your cluster:
    - Information about Scaled Objects : https://keda.sh/docs/latest/concepts/
    - Samples: https://github.com/kedacore/samples

Get information about the deployed ScaledObjects:
  kubectl get scaledobject [--namespace <namespace>]

Get details about a deployed ScaledObject:
  kubectl describe scaledobject <scaled-object-name> [--namespace <namespace>]

Get information about the deployed ScaledObjects:
  kubectl get triggerauthentication [--namespace <namespace>]

Get details about a deployed ScaledObject:
  kubectl describe triggerauthentication <trigger-authentication-name> [--namespace <namespace>]

Get an overview of the Horizontal Pod Autoscalers (HPA) that KEDA is using behind the scenes:
  kubectl get hpa [--all-namespaces] [--namespace <namespace>]

-------------------------------------------------------------------------------------

For more information on running KEDA, visit:
https://github.com/kedacore/keda/
=====================================================================================

@tomkerkhove tomkerkhove changed the title fix(core): Annotations are optional but enforced fix(core): Annotations are not handled correctly Jun 23, 2023
keda/templates/metrics-server/service.yaml Outdated Show resolved Hide resolved
keda/templates/manager/service.yaml Outdated Show resolved Hide resolved
keda/templates/webhooks/service.yaml Outdated Show resolved Hide resolved
@tomkerkhove tomkerkhove merged commit ba332ac into kedacore:main Jun 23, 2023
@tomkerkhove tomkerkhove deleted the annotations branch June 23, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Chart 2.11.0 Throws Errors
2 participants