Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KEDA crashes when using cert-manager certificates and restricted secret access #518

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Fix KEDA crashes when using cert-manager certificates and restricted secret access #518

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
84a116d
Fix KEDA crashes when using cert-manager certificates and restricted …
gjacquet Sep 8, 2023
b103bf6
revert version bump
gjacquet Sep 13, 2023
dbdf3b4
extra conditions
gjacquet Sep 25, 2023
10b6d9c
fix )
gjacquet Sep 25, 2023
b3689e4
extra conditions
gjacquet Sep 25, 2023
29038d2
Merge branch 'main' into cert-manager-restricted-secret-access
gjacquet Sep 25, 2023
3b69b8d
fix role creation logic
gjacquet Sep 25, 2023
be9a3ac
Update keda/templates/manager/role.yaml
gjacquet Sep 25, 2023
19959a1
Update keda/templates/manager/rolebinding.yaml
gjacquet Sep 25, 2023
aae6df5
fixes
gjacquet Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions keda/templates/manager/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.certificates.autoGenerated ( not .Values.certificates.certManager.enabled ) }}
{{- if or .Values.certificates.autoGenerated .Values.certificates.certManager.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
Expand All @@ -17,11 +17,13 @@ rules:
resources:
- secrets
verbs:
{{- if not .Values.certificates.certManager.enabled }}
- create
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that with my previous comment, the condition here should be if self generated AND NOT cert manager

- delete
- get
- list
- patch
- update
{{- end }}
- watch
- get
- list
{{- end -}}
2 changes: 1 addition & 1 deletion keda/templates/manager/rolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.certificates.autoGenerated ( not .Values.certificates.certManager.enabled ) }}
{{- if or .Values.certificates.autoGenerated .Values.certificates.certManager.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the other file comment for the condition

kind: RoleBinding
metadata:
Expand Down
Loading