feat: Support for enabling metrics in OpenTelemetry Collector #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SpiritZhou <[email protected]>
|
@SpiritZhou it is not needed to release a new chart version. Just add the otel support to resources. We will ship new Charts version during the release. |
tomkerkhove
changed the title
tomkerkhove
reviewed
Sep 28, 2023
| # -- Enable KEDA Operator opentelemetry metrics expose | ||
| enabled: false | ||
| # -- Set OTEL_EXPORTER_OTLP_ENDPOINT for opentelemetry exporter | ||
| otlpHTTPEndpoint: "" |
There was a problem hiding this comment.
I personally think it would be better to use opentelemetry.collector.uri or opentelemetry.collector.uri.http since this would be the same for all components ond otlp is not something we should add to the name
| @@ -139,6 +143,10 @@ spec: | |||
| - name: KEDA_RESTRICT_SECRET_ACCESS | |||
| value: {{ .Values.permissions.operator.restrict.secret | quote }} | |||
| {{- end }} | |||
| {{- if .Values.opentelemetry.operator.otlpHTTPEndpoint }} | |||
There was a problem hiding this comment.
We should only add it, if it's enabled as well
| @@ -87,6 +87,10 @@ spec: | |||
| - "--webhooks-service-name={{ .Values.webhooks.name }}" | |||
| {{- if .Values.prometheus.operator.enabled }} | |||
| - --metrics-bind-address=:{{ .Values.prometheus.operator.port }} | |||
| - --enable-prometheus-metrics=:{{ .Values.prometheus.operator.enabled }} | |||
| {{- end }} | |||
| {{- if .Values.opentelemetry.operator.enabled }} | |||
There was a problem hiding this comment.
If it's enabled but no collector URI was specified then we should fail
There was a problem hiding this comment.
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
tomkerkhove
added a commit
that referenced
this pull request
Sep 28, 2023
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Tom Kerkhove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update a chart helm for new experimental features
Checklist