feat(keda): Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates #530

zerodayyy · 2023-09-27T17:08:21Z

Allow user to provide reference to their own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Commits are signed with Developer Certificate of Origin (DCO - learn more)
README is updated with new configuration values (if applicable) learn more
A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

keda/Chart.yaml

keda/README.md

JorTurFer

Thanks for the improvement! I have left some comments inline

keda/Chart.yaml

keda/values.yaml

zerodayyy · 2023-10-02T14:28:33Z

@JorTurFer @zroubalik thanks for the review! I've updated the PR to address the comments

keda/templates/metrics-server/apiservice.yaml

keda/templates/webhooks/validatingconfiguration.yaml

keda/README.md

JorTurFer · 2023-10-03T21:56:39Z

Could you take a look to DCO check too? It's failing: https://github.com/kedacore/charts/pull/530/checks?check_run_id=17317958846

JorTurFer · 2023-10-13T21:05:05Z

DCO is still failing. You can check the process to fix it clicking here:

mcrivar · 2023-12-05T15:55:29Z

Any progress on these last steps failures?

Signed-off-by: Dmytro Kovalenko <[email protected]>

…wn Issuer Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Loïs Postula <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

…#506) Signed-off-by: Adarsh-verma-14 <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: yuval weber <[email protected]> Signed-off-by: unknown <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

#553) Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Adarsh-verma-14 <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

#572) * Add CloudEventSources Crd and ClustetName Parameter Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> * Update keda/values.yaml Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: SpiritZhou <[email protected]> * Fix Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> * Revert unnecessary update Signed-off-by: SpiritZhou <[email protected]> --------- Signed-off-by: SpiritZhou <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

* chore: Adjust RBAC with code Signed-off-by: Jorge Turrado <[email protected]> * fix typo Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Frank Kloeker <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Align deployment for extraVolumes and extraVolumesMount for fix problem Error: YAML parse error on keda/templates/webhooks/deployment.yaml: error converting YAML to JSON: yaml: line 96: did not find expected key Signed-off-by: ferndem <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

The current state of the Helm chart is slightly confusing, because: - There's no easy way to really disable prometheus metrics -- `--enable-prometheus-metrics` defaults to true anthe current code either emits `--enable-prometheus-metrics=true` or nothing at all (making it `true` once again). - The `http` container port is actually a `metrics` port (by convention from .e.g. webhook), but is present regardless of whether Prometheus metrics are enabled or not. To make it less confusing, this PR proposes renaming it. Signed-off-by: Milan Plzik <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: choisungwook <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

* support crd-specific annotations Signed-off-by: Adam Walford <[email protected]> * update readme Signed-off-by: Adam Walford <[email protected]> * update docs using helm-docs Signed-off-by: Adam Walford <[email protected]> --------- Signed-off-by: Adam Walford <[email protected]> Co-authored-by: Adam Walford <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

Co-authored-by: guicholeo <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Signed-off-by: Dmytro Kovalenko <[email protected]>

zerodayyy · 2024-01-24T15:33:20Z

Hey @zroubalik @JorTurFer I've addressed the comments and DCO check, could you please take a look? Thanks a lot

JorTurFer

LGTM!
Thanks for the improvement! ❤️

zerodayyy · 2024-02-03T20:49:44Z

Thanks! Just wondering, when are you planning to release a new chart version that would include this change?

JorTurFer · 2024-02-06T23:09:46Z

We don't have any expected date yet

JorTurFer · 2024-02-06T23:11:50Z

I gues that we could cut a helm release. WDYT @kedacore/keda-helm-contributors ?

zerodayyy · 2024-02-08T13:00:24Z

That would be great!

zerodayyy · 2024-02-14T14:30:39Z

Hey @JorTurFer @kedacore/keda-helm-contributors any leads when it would be possible to have this feature released (maybe as a patch version of the chart)? It would help a lot if it would be possible to release before KEDA itself has a new version. Thanks a lot!

zerodayyy requested a review from a team as a code owner September 27, 2023 17:08

zerodayyy changed the title ~~[keda] Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates~~ feat(keda): Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates Sep 27, 2023

zroubalik reviewed Sep 27, 2023

View reviewed changes

keda/Chart.yaml Outdated Show resolved Hide resolved

keda/README.md Outdated Show resolved Hide resolved

JorTurFer reviewed Sep 27, 2023

View reviewed changes

keda/Chart.yaml Outdated Show resolved Hide resolved

keda/values.yaml Outdated Show resolved Hide resolved

keda/values.yaml Outdated Show resolved Hide resolved

JorTurFer reviewed Oct 3, 2023

View reviewed changes

keda/templates/metrics-server/apiservice.yaml Outdated Show resolved Hide resolved

keda/templates/webhooks/validatingconfiguration.yaml Outdated Show resolved Hide resolved

keda/README.md Show resolved Hide resolved

Dmytro Kovalenko and others added 21 commits January 24, 2024 17:27

feat(keda): ✨ Allow providing own cert-manager issuer in TLS certificate

adcd4b3

Signed-off-by: Dmytro Kovalenko <[email protected]>

docs(keda): 📝 Generate Helm docs

9c50ff0

Signed-off-by: Dmytro Kovalenko <[email protected]>

fix(keda): 🐛 Inject CA from cert-manager Certificate when providing o…

e2b31ba

…wn Issuer Signed-off-by: Dmytro Kovalenko <[email protected]>

refactor(keda): ♻️ Refactor values format

7e1598c

Signed-off-by: Dmytro Kovalenko <[email protected]>

revert(keda): ⏪ Revert unnecessary auto-formatting

4ac1cee

Signed-off-by: Dmytro Kovalenko <[email protected]>

chore: Improve the CI on PRs to be more efficient (#540)

8460158

Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

fix(http-add-on): Refactor the chart for next version (#523)

09ebb19

Signed-off-by: Dmytro Kovalenko <[email protected]>

feat(add-on): Supporting streamInterval configuration (#541)

5a76c26

Signed-off-by: Dmytro Kovalenko <[email protected]>

chore(add-on): Ship Release 0.6.0 (#543)

18dadc9

Signed-off-by: Dmytro Kovalenko <[email protected]>

chore: update versions in README.md (#546)

c31d3b1

Signed-off-by: Dmytro Kovalenko <[email protected]>

feat: update crd to allow vault secret to handle write operation (#548)

78cabda

Signed-off-by: Loïs Postula <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Fix the svc name of webhook to avoid breaking istio (#551)

e49b2e0

Signed-off-by: Dmytro Kovalenko <[email protected]>

Show only logs with a severity level of ERROR or higher in the stderr (…

b1c614b

…#506) Signed-off-by: Adarsh-verma-14 <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Support profiling for keda components (#549)

c1a2a9c

Signed-off-by: yuval weber <[email protected]> Signed-off-by: unknown <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Fix TriggerAuthentication - added configuration for validation webhook (

098c817

#553) Signed-off-by: Dmytro Kovalenko <[email protected]>

fix: Declare missing port in KEDA operator (#552)

e256cb5

Signed-off-by: Dmytro Kovalenko <[email protected]>

Allow image registry override for all keda components (#557)

622a09d

Signed-off-by: Dmytro Kovalenko <[email protected]>

docs: Clarify that contributors do not have to ship Helm chart (#573)

bfad570

Signed-off-by: Dmytro Kovalenko <[email protected]>

add disable-compression arg for both operator and metrics-server (#554)

03210df

Signed-off-by: Adarsh-verma-14 <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

store 2.12.1 package at main (#577)

d8306da

Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

aballman and others added 18 commits January 24, 2024 17:27

Fix http-add-on operator resources (#567)

603d337

Signed-off-by: Dmytro Kovalenko <[email protected]>

Fix http-add-on verbosity configuration (#568)

ce6272c

Signed-off-by: Dmytro Kovalenko <[email protected]>

chore: Adjust RBAC with code (#585)

70d191c

* chore: Adjust RBAC with code Signed-off-by: Jorge Turrado <[email protected]> * fix typo Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

fix: Don't recreate CA with 8 months until it expires (#586)

298faeb

Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

feat(ClusterRole): Add RBAC rule to allow access to LimitRange (#588)

c81ba58

Signed-off-by: Dmytro Kovalenko <[email protected]>

remove not required insecureSkipTLSVerify (#564)

6c7c8e3

Signed-off-by: Frank Kloeker <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Fix Remove app.kubernetes.io/instance label in crd (#556)

b35727c

Signed-off-by: choisungwook <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Add ciliumnetworkpolicies (#558)

37b5c50

Signed-off-by: Dmytro Kovalenko <[email protected]>

Add tlsConfig for ServiceMonitor (#591)

4024f41

Co-authored-by: guicholeo <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

Release 2.13.0 (#593)

94c4412

Signed-off-by: Dmytro Kovalenko <[email protected]>

fix: Ship v2.13.1 with missing RoleBinding (#595)

dcd381e

Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

chore(add-on): Apply HTTP Add-on changes on Helm chart (#598)

4f28e7f

Signed-off-by: Dmytro Kovalenko <[email protected]>

chore(add-on): Release v0.7.0 (#599)

ec01f01

Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]>

refactor: Unify cert-manager annotations

8acf125

Signed-off-by: Dmytro Kovalenko <[email protected]>

Merge branch 'main' into main

cc8514b

zerodayyy requested review from zroubalik and JorTurFer January 28, 2024 12:16

JorTurFer approved these changes Jan 30, 2024

View reviewed changes

Merge branch 'main' into main

b4ef0e0

JorTurFer merged commit 4cf42b3 into kedacore:main Jan 30, 2024
37 checks passed

mkilchhofer mentioned this pull request Feb 10, 2024

chore: Simplify cert-manager certs and support existingIssuer #442

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(keda): Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates #530

feat(keda): Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates #530

zerodayyy commented Sep 27, 2023 •

edited

Loading

JorTurFer left a comment

zerodayyy commented Oct 2, 2023

JorTurFer commented Oct 3, 2023

JorTurFer commented Oct 13, 2023

mcrivar commented Dec 5, 2023

zerodayyy commented Jan 24, 2024

JorTurFer left a comment

zerodayyy commented Feb 3, 2024

JorTurFer commented Feb 6, 2024

JorTurFer commented Feb 6, 2024

zerodayyy commented Feb 8, 2024

zerodayyy commented Feb 14, 2024

feat(keda): Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates #530

feat(keda): Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates #530

Conversation

zerodayyy commented Sep 27, 2023 • edited Loading

Checklist

JorTurFer left a comment

Choose a reason for hiding this comment

zerodayyy commented Oct 2, 2023

JorTurFer commented Oct 3, 2023

JorTurFer commented Oct 13, 2023

mcrivar commented Dec 5, 2023

zerodayyy commented Jan 24, 2024

JorTurFer left a comment

Choose a reason for hiding this comment

zerodayyy commented Feb 3, 2024

JorTurFer commented Feb 6, 2024

JorTurFer commented Feb 6, 2024

zerodayyy commented Feb 8, 2024

zerodayyy commented Feb 14, 2024

zerodayyy commented Sep 27, 2023 •

edited

Loading