Allow customizing the metrics-server namespace #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Fernández <[email protected]>
JorTurFer
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Looking good. Please revert the changes related with new version (we ship them manually) and update the chart readme (https://github.com/kedacore/charts/blob/main/CONTRIBUTING.md#documentation)
| @@ -21,7 +21,7 @@ $ helm repo add kedacore https://kedacore.github.io/charts | |||
| $ helm search repo kedacore | |||
| NAME CHART VERSION APP VERSION DESCRIPTION | |||
| kedacore/external-scaler-azure-cosmos-db 0.1.0 0.1.0 Event-based autoscaler for Azure Cosmos DB chan... | |||
| kedacore/keda 2.14.2 2.14.0 Event-based autoscaler for workloads on Kubernetes | |||
| kedacore/keda 2.14.3 2.14.0 Event-based autoscaler for workloads on Kubernetes | |||
| @@ -8,7 +8,7 @@ kubeVersion: ">=v1.23.0-0" | |||
|
|
|||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| version: 2.14.2 | |||
| version: 2.14.3 | |||
4 tasks
zroubalik
reviewed
Aug 7, 2024
| @@ -277,6 +277,8 @@ rbac: | |||
|
|
|||
| # -- Whether RBAC for configured CRDs that can have a `scale` subresource should be created | |||
| enabledCustomScaledRefKinds: true | |||
| # -- Customize the namespace for metrics-server | |||
There was a problem hiding this comment.
We should highlight this is Kubernetes Metrics Server and not KEDA Metrics Server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to customize where
metrics-serveris installed, rather than defaultkube-system, so the roleBinding is created accordingly.Checklist
Fixes #645