fix: Replace wildcards in RBAC objects with explicit resources and verbs #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR look nice, but we can revert if by mistake during the release if we copy the RBAC from KEDA repo. Could you open a PR there too, changing the RBAC? 🙏 |
3 tasks
legal90
force-pushed
the
rbac-no-wildcards
branch
from
6817983
to
0464390
Compare
|
Thank you, @JorTurFer ! I submitted the similar PR to the main KEDA repo: kedacore/keda#6129 |
legal90
force-pushed
the
rbac-no-wildcards
branch
from
0464390
to
3bfed4e
Compare
Signed-off-by: Mikhail Zholobov <[email protected]>
Remove unnecessary "create" and "delete" verbs for CRs which are supposed to be created and deleted only by a user, and not by an operator. Signed-off-by: Mikhail Zholobov <[email protected]>
legal90
force-pushed
the
rbac-no-wildcards
branch
from
3bfed4e
to
55e2919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Kubernetes documentation and various k8s security guidelines, wildcards in resource and verb entries should be avoided:
Warning
Using wildcards in resource and verb entries could result in overly permissive access being granted to sensitive resources. For instance, if a new resource type is added, or a new subresource is added, or a new custom verb is checked, the wildcard entry automatically grants access, which may be undesirable. The principle of least privilege should be employed, using specific resources and verbs to ensure only the permissions required for the workload to function correctly are applied.
Refs:
This PR could be seen as a continuation of a previous work for hardening the RBAC: #625
It replaces
*with explicit verbs and resources, according to KEDA needs.Checklist
Similar PR to the main keda repo: kedacore/keda#6129