Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appProtocol to services collecting metrics using mTLS #688

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Add appProtocol to services collecting metrics using mTLS #688

merged 2 commits into from
Nov 7, 2024

Conversation

guicholeo
Copy link
Contributor

@guicholeo guicholeo commented Sep 12, 2024 •
edited
Loading

Adds appProtocol to the services collecting metrics using mTLS prometheus/prometheus#10213 (comment)

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #

@guicholeo guicholeo requested a review from a team as a code owner September 12, 2024 21:13
@guicholeo
Added appProtocol
889e537 
Signed-off-by: guicholeo <[email protected]>
@guicholeo guicholeo force-pushed the feature/add-app-protocol-to-services branch from 170e6b4 to 889e537 Compare September 12, 2024 21:14
@guicholeo guicholeo changed the title Add appProtocol to services using metrics Add appProtocol to services collecting metrics using mTLS Sep 12, 2024
@JorTurFer JorTurFer merged commit d57aae4 into kedacore:main Nov 7, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guicholeo @zroubalik @JorTurFer