Add Secret GET to keda-operator minimal RBAC #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Wozniak <[email protected]>
zroubalik
approved these changes
Sep 16, 2024
wozniakjan
added a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Jan Wozniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to: #643
Technically this PR is not necessary because the
keda-operatoruses an informer cache andGETrequests are handled internally (the cache is formed byLISTand thenWATCH), but this is to remain consistent with the documentation where all threeLIST,WATCHandGETare explicitly mentioned.https://keda.sh/docs/2.15/operate/cluster/#restrict-secret-access
Worthy to mention adding
GETalongLISTdoesn't elevate any permissions. It's an implementation detail of the RBAC in kube-apiserver.Checklist
Relates to: #685