Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Rename mentions of DataSet to Dataset in kedro-airflow and kedro-telemetry #384

Merged
merged 3 commits into from
Oct 11, 2023
Merged

style: Rename mentions of DataSet to Dataset in kedro-airflow and kedro-telemetry #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
377ae48
Rename DataSet mentions to Dataset in kedro-airflow
merelcht Oct 10, 2023
87a4daf
Rename DataSet mentions to Dataset in kedro-telemetry
merelcht Oct 10, 2023
ed2d57c
Merge branch 'main' into rename-mentions-of-dataset
merelcht Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions kedro-airflow/features/steps/cli_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,27 @@ def init_airflow(context, home_dir):
def prepare_old_catalog(context):
config = {
"example_train_x": {
"type": "PickleLocalDataSet",
"type": "PickleLocalDataset",
"filepath": "data/02_intermediate/example_train_x.pkl",
},
"example_train_y": {
"type": "PickleLocalDataSet",
"type": "PickleLocalDataset",
"filepath": "data/02_intermediate/example_train_y.pkl",
},
"example_test_x": {
"type": "PickleLocalDataSet",
"type": "PickleLocalDataset",
"filepath": "data/02_intermediate/example_test_x.pkl",
},
"example_test_y": {
"type": "PickleLocalDataSet",
"type": "PickleLocalDataset",
"filepath": "data/02_intermediate/example_test_y.pkl",
},
"example_model": {
"type": "PickleLocalDataSet",
"type": "PickleLocalDataset",
"filepath": "data/02_intermediate/example_model.pkl",
},
"example_predictions": {
"type": "PickleLocalDataSet",
"type": "PickleLocalDataset",
"filepath": "data/02_intermediate/example_predictions.pkl",
},
}
Expand All @@ -53,27 +53,27 @@ def prepare_old_catalog(context):
def prepare_catalog(context):
config = {
"example_train_x": {
"type": "pickle.PickleDataSet",
"type": "pickle.PickleDataset",
"filepath": "data/02_intermediate/example_train_x.pkl",
},
"example_train_y": {
"type": "pickle.PickleDataSet",
"type": "pickle.PickleDataset",
"filepath": "data/02_intermediate/example_train_y.pkl",
},
"example_test_x": {
"type": "pickle.PickleDataSet",
"type": "pickle.PickleDataset",
"filepath": "data/02_intermediate/example_test_x.pkl",
},
"example_test_y": {
"type": "pickle.PickleDataSet",
"type": "pickle.PickleDataset",
"filepath": "data/02_intermediate/example_test_y.pkl",
},
"example_model": {
"type": "pickle.PickleDataSet",
"type": "pickle.PickleDataset",
"filepath": "data/02_intermediate/example_model.pkl",
},
"example_predictions": {
"type": "pickle.PickleDataSet",
"type": "pickle.PickleDataset",
"filepath": "data/02_intermediate/example_predictions.pkl",
},
}
Expand Down
8 changes: 4 additions & 4 deletions kedro-telemetry/tests/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from kedro import __version__ as kedro_version
from kedro.framework.project import pipelines
from kedro.framework.startup import ProjectMetadata
from kedro.io import DataCatalog, MemoryDataSet
from kedro.io import DataCatalog, MemoryDataset
from kedro.pipeline import node
from kedro.pipeline.modular_pipeline import pipeline as modular_pipeline
from pytest import fixture
Expand Down Expand Up @@ -40,9 +40,9 @@ def fake_metadata(tmp_path):
@fixture
def fake_context(mocker):
mock_context = mocker.Mock()
dummy_1 = MemoryDataSet()
dummy_2 = MemoryDataSet()
dummy_3 = MemoryDataSet()
dummy_1 = MemoryDataset()
dummy_2 = MemoryDataset()
dummy_3 = MemoryDataset()
mock_context.catalog = DataCatalog(
{"dummy_1": dummy_1, "dummy_2": dummy_2, "dummy_3": dummy_3}
)
Expand Down