-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(datasets): Remove tracking datasets which are used in Kedro Viz Experiment Tracking #969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ravi-kumar-pilla !
Hi @ankatiyar and @DimedS , The docs build fails as dask deprecated the usage of Thank you |
@ravi-kumar-pilla The docs fix seems fine for now, if the dataset itself is working fine. We can create an issue for the migration! |
I agree, thanks @ravi-kumar-pilla and @ankatiyar ! |
Hi @ankatiyar and @DimedS , Thanks for the response. After further reading, I found that Dask-Expr is a new backend for Dask DataFrame that provides query optimization and other performance improvements. Starting with Dask version 2024.3, it became the default backend. I don't think there is a need for migration from our side unless we plan to opt out of the optimization by setting the below config - import dask
dask.config.set({'dataframe.query-planning': False}) As per the docs, they actually updated the docs link as mentioned here. So the fix in this PR is suffice. Thank you |
Description
Resolves kedro-org/kedro#4370
NOTE: This should be merged after kedro-datasets 6.0.0 release
Development notes
json_dataset
andmetrics_dataset
Checklist
jsonschema/kedro-catalog-X.XX.json
if necessaryRELEASE.md
file