Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all mentions of DataSet to Dataset #155

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Rename all mentions of DataSet to Dataset #155

merged 1 commit into from
Oct 10, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Oct 9, 2023

Motivation and Context

Part of kedro-org/kedro#2129

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@merelcht merelcht marked this pull request as ready for review October 10, 2023 08:47
@merelcht merelcht mentioned this pull request Oct 10, 2023
Closed
9 tasks
@merelcht merelcht self-assigned this Oct 10, 2023
lrcouto
lrcouto approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@lrcouto lrcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merelcht merelcht merged commit db254b4 into main Oct 10, 2023
18 checks passed
@merelcht merelcht deleted the rename-all-mentions-of-dataset branch October 10, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhdraMeraliQB AhdraMeraliQB AhdraMeraliQB approved these changes

@lrcouto lrcouto lrcouto approved these changes

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merelcht @lrcouto @AhdraMeraliQB