Mention upcoming removal and rename of datasets in docs + release notes #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <[email protected]>
merelcht
requested review from
yetudada,
astrojuanlu and
stichbury
as code owners
merelcht
requested review from
deepyaman
and removed request for
astrojuanlu and
yetudada
9 tasks
stichbury
reviewed
Oct 11, 2023
stichbury
reviewed
Oct 11, 2023
stichbury
reviewed
Oct 11, 2023
stichbury
suggested changes
Oct 11, 2023
Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Thanks Jo, I've updated this now across all files. |
stichbury
approved these changes
Oct 11, 2023
astrojuanlu
approved these changes
Oct 11, 2023
| @@ -20,6 +20,9 @@ | |||
| * Added documentation to clarify execution order of hooks. | |||
| ## Breaking changes to the API | |||
| ## Upcoming deprecations for Kedro 0.19.0 | |||
| * All dataset classes will be removed from the core Kedro repository (`kedro.extras.datasets`). Install and import them from the [`kedro-datasets`](https://github.com/kedro-org/kedro-plugins/tree/main/kedro-datasets) package instead. | |||
There was a problem hiding this comment.
Was this a new deprecation? This was already noted in 0.18.8 (see this same document, far below)
There was a problem hiding this comment.
Ah I missed that.. so technically it's not new, but in 0.18.8 it fell under documentation, and I also feel that this is probably significant enough to mention again. WDYT?
There was a problem hiding this comment.
Doesn't hurt to emphasize it there again! 👍🏽
| @@ -20,6 +20,9 @@ | |||
| * Added documentation to clarify execution order of hooks. | |||
| ## Breaking changes to the API | |||
| ## Upcoming deprecations for Kedro 0.19.0 | |||
| * All dataset classes will be removed from the core Kedro repository (`kedro.extras.datasets`). Install and import them from the [`kedro-datasets`](https://github.com/kedro-org/kedro-plugins/tree/main/kedro-datasets) package instead. | |||
| * All dataset classes ending with `DataSet` are deprecated and will be removed in Kedro `0.19.0` and `kedro-datasets` `2.0.0`. Instead, use the updated class names ending with `Dataset`. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #2129
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile