Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop _load and _save in core datasets and docs #4044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Jul 30, 2024

Description

Take advantage of the ability to define load and save publicly in Kedro core (separate PR for Kedro-Datasets upcoming), and provide guidance to users to do the same.

There's no new core functionality introduced here.

Development notes

I removed this from the initial #3920, due to potentially breaking changes for Kedro-MLflow users. Now, Galileo-Galilei/kedro-mlflow#590 has been merged (I had created this PR months ago, as you can see, but had been slow on unblocking Kedro-MLflow), so there is a clear path forward for Kedro-MLflow.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@deepyaman deepyaman force-pushed the chore/remove-underscore-load-and-save branch 3 times, most recently from 5a11ae0 to 432d7b4 Compare August 7, 2024 16:18
@deepyaman deepyaman force-pushed the chore/remove-underscore-load-and-save branch from 432d7b4 to d01707d Compare September 9, 2024 22:02
@deepyaman deepyaman marked this pull request as ready for review September 9, 2024 23:21
@deepyaman deepyaman self-assigned this Sep 9, 2024
@deepyaman deepyaman enabled auto-merge (squash) September 10, 2024 12:57
@deepyaman deepyaman force-pushed the chore/remove-underscore-load-and-save branch from d01707d to 17541c1 Compare September 12, 2024 17:20
@deepyaman deepyaman force-pushed the chore/remove-underscore-load-and-save branch from 17541c1 to 6eb0524 Compare September 17, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant