-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for oss
to cloud protocols
#4082
Conversation
CLOUD_PROTOCOLS add more official fsspec implament (oss, swift,dropbox) Signed-off-by: rong fengliang <[email protected]>
oss
, swift
, and dropbox
to cloud protocols
Hi @rongfengliang, thanks for opening this PR! 🙂 I see in the description you say:
Would it be possible for you to try the other protocols as well? I'd feel more comfortable adding it to the codebase knowing it works. Thanks! |
Signed-off-by: rong fengliang <[email protected]>
oss
, swift
, and dropbox
to cloud protocolsoss
to cloud protocols
@merelcht |
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to test this myself but I checked that fsspec
does have an oss
protocol so I expect it works the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @rongfengliang
CLOUD_PROTOCOLS add more official fsspec implament (oss, swift,dropbox)
Description
CLOUD_PROTOCOLS add more official fsspec implament (oss, swift,dropbox)
Development notes
I have test with oss , others maybe also OK
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file