Make credentials loading consistent between KedroContext._get_catalog()
and catalog CLI
#4165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that credentials initialization is done differently in different cases:
resolve_patterns()
, it is done withcontext.config_loader.get("credentials", None)
insteadIs there a good reason for this? If not, I think it's better to load the credentials in a consistent way and using the same methods everywhere
Why is this important?
I have a custom catalog class that extends
KedroCatalog
and overrides the_get_config_credentials()
method because I get my credentials from a cloud secret management service instead of a localcredentials.yml
file.This was making the command
kedro catalog resolve
fail because my credentials are not in theConfigLoader
Checklist
RELEASE.md
file