-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mathematica Icon #520
base: master
Are you sure you want to change the base?
Mathematica Icon #520
Conversation
…a, Torrent, Virtual-box, Wine, Yandex-disk)
Like to #507 this still contains way too many unrelated changes. This PR should contain additions /changes for a Mathematica icon only - if you want to contribute icons for multiple applications, make a single PR for every icon. That might not sound straightforward, but is usually the best solution. I'd suggest you should make yourself familiar with the basics of git if necessary, e.g. using this for reference: https://git-scm.com/docs/gittutorial |
Thanks for your valuable suggestion.. I will make different request for each contribution, what should I do now should I revert is back to the Mathematica icons only |
@s1-ranjan please run EDIT: see the wiki |
@keeferrourke I have used |
@s1-ranjan I have one last nit-pick before we merge this in -- the text on the mimetype icons shouldn't be ALL CAPS. Please use lower case Roboto size 9 text... then select the text and convert it to a path. When this change is made, please run the following, where MYFILE is the name of the file to cleaned up. svgcleaner MYFILE.svg MYFILE.svg
tidy -q -xml -indent -wrap 0 -m MYFILE.svg You can install |
@keeferrourke I have seen a mime type naming is having all the text in ALL CAPS. i.e. text-x-matlab.svg please have a look at this mimetype. |
@s1-ranjan thanks for identifying this, I've filed a new issue and will take some time to improve the consistency of our mimetype icons over the coming few weeks! 🙏 |
@keeferrourke ALL CAPS issue has been fixed for Mathematica, now it can be merged. |
@keeferrourke Should I Close this pull request, as I have few more fixes to push |
@s1-ranjan if you want to open a new PR, go for it! |
This reverts commit f63768b.
…t, Virtual-box, Yandex-disk)
I have added Mathematica Icon and it's Mimetypes