Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathematica Icon #520

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Mathematica Icon #520

wants to merge 22 commits into from

Conversation

s1-ranjan
Copy link

I have added Mathematica Icon and it's Mimetypes

@linusg
Copy link
Contributor

linusg commented Dec 20, 2019

Like to #507 this still contains way too many unrelated changes. This PR should contain additions /changes for a Mathematica icon only - if you want to contribute icons for multiple applications, make a single PR for every icon. That might not sound straightforward, but is usually the best solution.

I'd suggest you should make yourself familiar with the basics of git if necessary, e.g. using this for reference: https://git-scm.com/docs/gittutorial

@s1-ranjan
Copy link
Author

Thanks for your valuable suggestion.. I will make different request for each contribution, what should I do now should I revert is back to the Mathematica icons only

This reverts commit a1bbec5.
…nux, Mega, Torrent, Virtual-box, Wine, Yandex-disk)"

This reverts commit 8b5858b.
This reverts commit b3df919.
This reverts commit 4930b4c.
@keeferrourke
Copy link
Owner

keeferrourke commented Jan 9, 2020

@s1-ranjan please run svgcleaner and tidy over all the icons present in the PR. Thanks!

EDIT: see the wiki

@s1-ranjan
Copy link
Author

@keeferrourke I have used scour and tidy as these were available in my repository, running these tools on all the icons is a tedious job, so I ran this task on the files that I have created.

@keeferrourke
Copy link
Owner

@s1-ranjan I have one last nit-pick before we merge this in -- the text on the mimetype icons shouldn't be ALL CAPS. Please use lower case Roboto size 9 text... then select the text and convert it to a path.

When this change is made, please run the following, where MYFILE is the name of the file to cleaned up.

svgcleaner MYFILE.svg MYFILE.svg
tidy -q -xml -indent -wrap 0 -m MYFILE.svg

You can install svgcleaner via the Rust tool cargo if its not packaged in your regular distribution repositories.

@s1-ranjan
Copy link
Author

s1-ranjan commented Jan 15, 2020

@keeferrourke I have seen a mime type naming is having all the text in ALL CAPS. i.e. text-x-matlab.svg please have a look at this mimetype.

@keeferrourke
Copy link
Owner

@s1-ranjan thanks for identifying this, I've filed a new issue and will take some time to improve the consistency of our mimetype icons over the coming few weeks! 🙏

@s1-ranjan
Copy link
Author

s1-ranjan commented Jan 19, 2020

@keeferrourke ALL CAPS issue has been fixed for Mathematica, now it can be merged.

@s1-ranjan
Copy link
Author

@keeferrourke Should I Close this pull request, as I have few more fixes to push

@keeferrourke
Copy link
Owner

@s1-ranjan if you want to open a new PR, go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants