feat: macros package #324
Merged
feat: macros package #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
reviewed
Aug 21, 2024
Co-authored-by: Marek Kaput <[email protected]>
enitrat
approved these changes
Aug 22, 2024
2 tasks
0xLucqs
approved these changes
Aug 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
Description
This PR introduces a new Alexandria package,
alexandria_macros. The idea is to group any and all useful macros in here. As an introduction, it also adds a humblepow!macro that calculates x to the power of y. I hope many more will follow.Because Cairo macros are Rust programs, I added a new separate GitHub workflow just to test macros. Also because of the way macros work (at least to my understanding), I added a
macros_testsdirectory that serves just as a dummy Scarb project to run tests on; it is not part of the Alexandria workspace. Not sure this is the best way to go about it, but having the tests inside the main macros package didn't work for me (i.e. I didn't find a way how to do it, if there's some, I'm happy to amend the PR).Does this introduce a breaking change?
Other information