Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to scarb 2.9.2 #342

Merged

Conversation

ishay-starkware
Copy link
Contributor

@ishay-starkware ishay-starkware commented Dec 13, 2024

bump scarb to 2.9.2
add missing data_structures package dependency to encoding package
update bigdecimal to 0.4.7 in macros package
update cairo-lang-macro to 0.1.1 in macros package cargo.toml
update cairo-lang-parser 2.9.2 in macros package cargo.toml
update cairo-lang-syntax 2.9.2 in macros package cargo.toml

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): update version

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ishay-starkware ishay-starkware mentioned this pull request Dec 13, 2024
2 tasks
Copy link

@huynhducduy huynhducduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaetbout
Copy link
Collaborator

Ping me once it is good to be merged

@ishay-starkware
Copy link
Contributor Author

ishay-starkware commented Dec 16, 2024

@gaetbout There's an issue with the code in the macros package with the new Cairo version. The pow! macro isn't working. To be honest I think that this macro can be removed as they added pow to the corelib.
@0xLucqs FYI

@gaetbout
Copy link
Collaborator

I think, this was more to showcase how to make your own macro.
@milancermak, can you help here?

@0xLucqs
Copy link
Collaborator

0xLucqs commented Dec 16, 2024

I’ll push the fix tomorrow

@milancermak
Copy link
Contributor

I think it's still worth keeping it. The macro calculates the result at compile time (i.e. it's a constant), it's nice to have sth like pow!(10, 18) instead of 1000000000000000000 for readability, esp. in defi apps.

@0xLucqs 0xLucqs merged commit 162bed1 into keep-starknet-strange:main Dec 18, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants