-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump to scarb 2.9.2 #342
feat: bump to scarb 2.9.2 #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ping me once it is good to be merged |
@gaetbout There's an issue with the code in the macros package with the new Cairo version. The pow! macro isn't working. To be honest I think that this macro can be removed as they added pow to the corelib. |
I think, this was more to showcase how to make your own macro. |
I’ll push the fix tomorrow |
I think it's still worth keeping it. The macro calculates the result at compile time (i.e. it's a constant), it's nice to have sth like |
bump
scarb
to 2.9.2add missing
data_structures
package dependency to encoding packageupdate
bigdecimal
to 0.4.7 in macros packageupdate
cairo-lang-macro
to 0.1.1 inmacros
package cargo.tomlupdate
cairo-lang-parser
2.9.2 inmacros
package cargo.tomlupdate
cairo-lang-syntax
2.9.2 inmacros
package cargo.tomlPull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information