Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): setters for each event field #2

Merged
merged 2 commits into from
Oct 14, 2024
Merged

feat(backend): setters for each event field #2

merged 2 commits into from
Oct 14, 2024

Conversation

0xLucqs
Copy link
Contributor

@0xLucqs 0xLucqs commented Oct 11, 2024

No description provided.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (9e00b8c) to head (0ec8231).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...kend/lib/peach_web/controllers/event_controller.ex 83.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   69.81%   77.27%   +7.46%     
==========================================
  Files          17       17              
  Lines         106      154      +48     
==========================================
+ Hits           74      119      +45     
- Misses         32       35       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xChqrles 0xChqrles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an Elixir expert, it lgtm ! Well Done Lucqs

@0xLucqs 0xLucqs merged commit 52730d3 into main Oct 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants