wip: FixingBlock 174731 - ids.a Expected as Integer
#431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
reviewed
Nov 15, 2024
| from starkware.cairo.common.cairo_builtins import HashBuiltin | ||
| from starkware.starknet.common.syscalls import library_call, library_call_l1_handler | ||
| from starkware.cairo.common.math import assert_not_zero | ||
|
|
There was a problem hiding this comment.
If there's any context you can add about this file (where it came from, why we have it, etc.) it would be good to add here.
notlesh
reviewed
Nov 15, 2024
Comment on lines
74
to
90
| @raw_input | ||
| @external | ||
| func __validate_deploy__{ | ||
| syscall_ptr: felt*, | ||
| pedersen_ptr: HashBuiltin*, | ||
| ecdsa_ptr: SignatureBuiltin*, | ||
| range_check_ptr | ||
| } (selector: felt, calldata_size: felt, calldata: felt*) { | ||
| alloc_locals; | ||
| // get the tx info | ||
| let (tx_info) = get_tx_info(); | ||
| with_attr error_message("assertion failed") { | ||
| assert_nn(tx_info.signature_len - 2); | ||
| } | ||
|
|
||
| return (); | ||
| } |
There was a problem hiding this comment.
Is this still needed? If we don't need all of the unusual things here (e.g. @raw_input) in order to test this (as a regression test) then I would suggest removing it or at least adding some documentation about it. Otherwise I can see it adding a lot of confusion in the future.
notlesh
reviewed
Nov 15, 2024
|
|
||
| #[rstest] | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 1)] | ||
| async fn deploy_cairo0_via_proxy(block_context: BlockContext, max_fee: Fee) { |
There was a problem hiding this comment.
Does the proxy impact this bug at all? I might apply my same concerns above if not, this is likely to add confusion in the future.
notlesh
reviewed
Nov 15, 2024
| let deprecated_tx_info_ptr = | ||
| get_relocatable_from_var_name(vars::ids::DEPRECATED_TX_INFO, vm, ids_data, ap_tracking)?; | ||
| let deprecated_tx_info_ptr = get_ptr_from_var_name(vars::ids::DEPRECATED_TX_INFO, vm, ids_data, ap_tracking)?; |
notlesh
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #429
Type
Description
The issue is triggered when calling the
get_tx_info()function inside__validate_deploy__.The steps to fix the issue:
Breaking changes?