CLI: Restore the original codepage on windows #11470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11470 +/- ##
========================================
Coverage 63.91% 63.91%
========================================
Files 362 362
Lines 38146 38147 +1
========================================
+ Hits 24379 24380 +1
Misses 13767 13767 ☔ View full report in Codecov by Sentry. |
phoerious
reviewed
Nov 19, 2024
droidmonkey
force-pushed
the
fix/restore-cp
branch
from
d8d4c62 to
fd5b533
Compare
|
@phoerious ready for re-review |
phoerious
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested on Windows
Type of change