Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple crashes on Linux #11513

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Fix multiple crashes on Linux #11513

merged 2 commits into from
Nov 30, 2024

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Nov 29, 2024

Fix crash when multiple dbus unlock calls are issued

Fix crash on Linux when database is closed without hardware key present

Testing strategy

Tested before/after change, crash no longer occurs with guard in place

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (bf856d2) to head (ecfbead).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/DatabaseOpenWidget.cpp 33.33% 2 Missing ⚠️
src/gui/osutils/DeviceListener.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #11513   +/-   ##
========================================
  Coverage    63.88%   63.88%           
========================================
  Files          362      362           
  Lines        38140    38143    +3     
========================================
+ Hits         24363    24365    +2     
- Misses       13777    13778    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey changed the title Fix crash when multiple dbus unlock calls are issued Fix multiple crashes on Linux Nov 30, 2024
@droidmonkey droidmonkey force-pushed the fix/dbus-unlock-crash branch from bd1ed26 to ecfbead Compare November 30, 2024 15:16
@droidmonkey droidmonkey merged commit 9a63e80 into develop Nov 30, 2024
11 checks passed
@droidmonkey droidmonkey deleted the fix/dbus-unlock-crash branch November 30, 2024 20:07
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash 💥 platform: Linux pr: backported Pull request backported to previous release
Projects
None yet
2 participants