fix: do not reload the page on the webhook installation

keephq · Oct 13, 2024 · 653d837 · 653d837
1 parent df34719
commit 653d837
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/keep-ui/app/globals.css b/keep-ui/app/globals.css
@@ -45,3 +45,7 @@
   }
 }
 
+.sliding-panel-container.active {
+  /* original value is ridiculous 15.000, overflowing toasts*/
+  @apply z-[1000] !important;
+}
diff --git a/keep-ui/app/providers/provider-form.tsx b/keep-ui/app/providers/provider-form.tsx
@@ -202,8 +202,8 @@ const ProviderForm = ({
   const accessToken = session?.accessToken;
 
   const callInstallWebhook = async (e: Event) => {
-    await installWebhook(provider, accessToken!);
     e.preventDefault();
+    await installWebhook(provider, accessToken!);
   };
 
   async function handleOauth(e: MouseEvent) {
@@ -214,7 +214,7 @@ const ProviderForm = ({
 
     let oauth2Url = provider.oauth2_url;
     if (searchParams?.get("domain")) {
-      // TODO: this is a hack for Datadog OAuth2 since it can be initated from different domains
+      // TODO: this is a hack for Datadog OAuth2 since it can be initiated from different domains
       oauth2Url = oauth2Url?.replace(
         "datadoghq.com",
         searchParams.get("domain")

diff --git a/keep-ui/app/providers/providers-tiles.tsx b/keep-ui/app/providers/providers-tiles.tsx
@@ -2,6 +2,7 @@
 import { Icon, Title } from "@tremor/react";
 import { Providers, Provider } from "./providers";
 import { useEffect, useState } from "react";
+// TODO: replace with custom component, package is not updated for last 4 years
 import SlidingPanel from "react-sliding-side-panel";
 import ProviderForm from "./provider-form";
 import ProviderTile from "./provider-tile";
@@ -151,7 +152,7 @@ const ProvidersTiles = ({
         isOpen={openPanel}
         size={panelSize}
         backdropClicked={handleCloseModal}
-        panelContainerClassName="bg-white z-[2000]"
+        panelContainerClassName="bg-white z-[100]"
       >
         {selectedProvider && (
           <ProviderForm