-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added dashboard for Alert Quality #1977
base: main
Are you sure you want to change the base?
Conversation
@vikashsprem is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Hey @vikashsprem how is it going? :) |
Hey, @Matvey-Kuk going great, need some time to complete it. |
Hey @Matvey-Kuk, @rajeshj11 is also collaborating with me (To complete this issue sooner). Most of the portions are completed. Thank you. |
β¦fications on forntend
feat: added the quality metrics stats logic in backend and minor modification on forntend
feat: added the providers filter tabs and custom filters
Hey @Matvey-Kuk, Please review this PR and let me know if any changes. |
feat: intergated the custom filters
Hey @vikashsprem I see you added a separate page for this dashboard, what do you think of making it a widget for the dashboard we already have? :) |
Hey @Matvey-Kuk , Thanks for the suggestion! My concern with making it a widget is that the separate page allows us to include more detailed functionality without crowding the main dashboard. But I'm happy to discuss and find the best approach! |
@vikashsprem the main dashboard has a timeframe selector, also we're planning to add more widgets to this dashboard in the future to allow users to tail dashboards to their needs. |
@Matvey-Kuk Got it, that makes sense! I'll look into transitioning the separate page into a widget. |
feat: move the quality table report to dashbaord.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
===========================================
- Coverage 71.20% 31.91% -39.30%
===========================================
Files 154 63 -91
Lines 14046 6511 -7535
===========================================
- Hits 10002 2078 -7924
- Misses 4044 4433 +389 β View full report in Codecov by Sentry. |
@talboren @Matvey-Kuk We have worked on the feedback changes. can you please review now |
Will review shortly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep-ui/app/alerts/quality/page.tsx
Outdated
@@ -0,0 +1,12 @@ | |||
import QualityAlert from './alert-quality-table'; // Adjust the import path if needed | |||
|
|||
const AlertQualityPage = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't need this page anymore, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
Mostly post deletion. You have not installed any providers. We are showing only installed metrics @Matvey-Kuk ^^ Have you checked my comment?? |
chore: remove unwanted page
@Matvey-Kuk @talboren I wanted to follow up on this PR, as it seems to have been pending for a while. |
Closes #1779
/claim #1779
π Description
β Checks
βΉ Additional Information