Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added dashboard for Alert Quality #1977

Open
wants to merge 66 commits into
base: main
Choose a base branch
from

Conversation

vikashsprem
Copy link

@vikashsprem vikashsprem commented Sep 21, 2024

Closes #1779
/claim #1779

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Sep 21, 2024

@vikashsprem is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2024

CLA assistant check
All committers have signed the CLA.

@vikashsprem vikashsprem marked this pull request as draft September 21, 2024 16:07
@vikashsprem vikashsprem changed the title Added UI for Alert Quality dashboard [Feat]: Added dashboard for Alert Quality Sep 21, 2024
@Matvey-Kuk
Copy link
Contributor

Hey @vikashsprem how is it going? :)

@vikashsprem
Copy link
Author

Hey, @Matvey-Kuk going great, need some time to complete it.

@vikashsprem
Copy link
Author

vikashsprem commented Sep 26, 2024

Hey @Matvey-Kuk, @rajeshj11 is also collaborating with me (To complete this issue sooner). Most of the portions are completed. Thank you.

rajeshj11 and others added 4 commits September 27, 2024 01:12
feat: added the quality metrics stats logic in backend and minor modification on forntend
feat: added the providers filter tabs and custom filters
@vikashsprem
Copy link
Author

Hey @Matvey-Kuk, Please review this PR and let me know if any changes.

Screenshot 2024-09-27 at 1 15 06β€―PM

@vikashsprem vikashsprem marked this pull request as ready for review September 27, 2024 07:51
@vikashsprem vikashsprem changed the title [Feat]: Added dashboard for Alert Quality feat: Added dashboard for Alert Quality Sep 27, 2024
@Matvey-Kuk
Copy link
Contributor

Hey @vikashsprem I see you added a separate page for this dashboard, what do you think of making it a widget for the dashboard we already have? :)

@vikashsprem
Copy link
Author

vikashsprem commented Sep 27, 2024

Hey @Matvey-Kuk , Thanks for the suggestion! My concern with making it a widget is that the separate page allows us to include more detailed functionality without crowding the main dashboard. But I'm happy to discuss and find the best approach!

@Matvey-Kuk
Copy link
Contributor

@vikashsprem the main dashboard has a timeframe selector, also we're planning to add more widgets to this dashboard in the future to allow users to tail dashboards to their needs.

@vikashsprem
Copy link
Author

@Matvey-Kuk Got it, that makes sense! I'll look into transitioning the separate page into a widget.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 31.91%. Comparing base (7d90ae9) to head (26abf15).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1977       +/-   ##
===========================================
- Coverage   71.20%   31.91%   -39.30%     
===========================================
  Files         154       63       -91     
  Lines       14046     6511     -7535     
===========================================
- Hits        10002     2078     -7924     
- Misses       4044     4433      +389     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@rajeshj11
Copy link
Contributor

@talboren @Matvey-Kuk We have worked on the feedback changes. can you please review now

@Matvey-Kuk
Copy link
Contributor

Will review shortly!

Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason it doesn't render for me even though the API call seems to be working perfecly:
Screenshot 2024-10-13 at 10 43 09

To reproduce:

  1. Remove db.
  2. Shoot scripts/simulate_alerts.py
  3. Create dashboard, add the widget.

@@ -0,0 +1,12 @@
import QualityAlert from './alert-quality-table'; // Adjust the import path if needed

const AlertQualityPage = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need this page anymore, right?

Copy link
Contributor

@rajeshj11 rajeshj11 Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@rajeshj11
Copy link
Contributor

For some reason it doesn't render for me even though the API call seems to be working perfecly: Screenshot 2024-10-13 at 10 43 09

To reproduce:

  1. Remove db.
  2. Shoot scripts/simulate_alerts.py
  3. Create dashboard, add the widget.

Will check

@rajeshj11
Copy link
Contributor

rajeshj11 commented Oct 13, 2024

For some reason it doesn't render for me even though the API call seems to be working perfecly: Screenshot 2024-10-13 at 10 43 09
To reproduce:

  1. Remove db.
  2. Shoot scripts/simulate_alerts.py
  3. Create dashboard, add the widget.

Will check

Mostly post deletion. You have not installed any providers. We are showing only installed metrics
Cc: @talboren

@Matvey-Kuk ^^ Have you checked my comment??

@rajeshj11
Copy link
Contributor

@Matvey-Kuk @talboren I wanted to follow up on this PR, as it seems to have been pending for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Alert quality widgets for a dashboard
5 participants