Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update enrichment.mdx #3001

Merged
merged 8 commits into from
Jan 14, 2025
Merged

docs: update enrichment.mdx #3001

merged 8 commits into from
Jan 14, 2025

Conversation

00041275
Copy link
Contributor

@00041275 00041275 commented Jan 9, 2025

Close #2995
added to doc

Signed-off-by: Adilbek Kangerey <[email protected]>
Copy link

vercel bot commented Jan 9, 2025

@00041275 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Documentation Improvements or additions to documentation labels Jan 9, 2025
@00041275
Copy link
Contributor Author

00041275 commented Jan 9, 2025

Actually i can't understand how is work example resolve_old_alerts (#2995) in issue

@shahargl
Copy link
Member

shahargl commented Jan 9, 2025

Hey @00041275 - first, thanks for contributing! Second - can I help somehow? Do you have some open question? I see you know what disposable enrichment is doing 😅

@talboren talboren changed the title Update enrichment.mdx docs: update enrichment.mdx Jan 9, 2025
@talboren
Copy link
Member

talboren commented Jan 9, 2025

Actually i can't understand how is work example resolve is issue

Updated the title to match conventional commits standard

docs/workflows/syntax/enrichment.mdx Outdated Show resolved Hide resolved
Signed-off-by: Adilbek Kangerey <[email protected]>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 9, 2025
Signed-off-by: Adilbek Kangerey <[email protected]>
@00041275
Copy link
Contributor Author

00041275 commented Jan 9, 2025

Hey @00041275 - first, thanks for contributing! Second - can I help somehow? Do you have some open question? I see you know what disposable enrichment is doing 😅

yes please actually i can't understand example resolve_old_alerts. please give me logic to know about it.
(https://github.com/keephq/keep/blob/main/examples/workflows/resolve_old_alerts.yml)

workflow:
  id: resolve-old-alerts
  description:
  triggers:
    - type: manual
    - type: interval
      value: 60
  steps:
    # get the alerts from keep
    - name: get-alerts
      provider:
        type: keep
        with:
          version: 2
          filter: "status == 'firing'"
  actions:
    - name: resolve-alerts
      foreach: " {{ steps.get-alerts.results }} "
      if: "keep.to_timestamp('{{ foreach.value.lastReceived }}') < keep.utcnowtimestamp() - 3600"
      provider:
        type: mock
        with:
          enrich_alert: 
         #HOW ENRICH ALERT KNOW ABOUT ALERT ON INTERVAL? 
          - key: status
            value: resolved
            disposable: true

@00041275
Copy link
Contributor Author

@shahargl I was write example for working with enrichment in trigger for #2995, please look it.
@talboren I was clean duplicated text, please merge it

talboren
talboren previously approved these changes Jan 13, 2025
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 13, 2025
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 8:08am

@talboren
Copy link
Member

@00041275 should I proceed with merging it?

talboren and others added 2 commits January 14, 2025 07:58
add 
A workaround is to use a foreach directive and pass it an object containing the "fingerprint" variable.

Signed-off-by: Adilbek Kangerey <[email protected]>
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@talboren talboren enabled auto-merge (squash) January 14, 2025 08:08
@talboren talboren merged commit 6df554b into keephq:main Jan 14, 2025
8 checks passed
Copy link
Contributor

🌟 High five, @00041275! You've hit the incredible milestone of 5 merged PRs! 🖐️✨

Your dedication to keep is outstanding. You're not just contributing code; you're shaping the future of this project! 🌠
We'd love to hear your thoughts on the project. Any ideas for new features or improvements? 🤔

The whole team applaud your efforts. You're a superstar! 🌟

@00041275 00041275 deleted the patch-4 branch January 14, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📃 Docs]: disposable and enrich alert in trigger interval or manual (from workflow page) or incident
3 participants