Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore warnings at import time in astrometry.net #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keflavich
Copy link
Owner

addresses issue astropy#1544 by explicitly ignoring warnings when the instance of the astrometry.net class is created at import time.

@keflavich
Copy link
Owner Author

this wasn't supposed to be a PR onto my own branch, but after thinking more, I don't think we should make this change

@codecov-commenter
Copy link

Codecov Report

Merging #18 (4738822) into main (5ca7593) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files         411      411           
  Lines       27212    27212           
=======================================
  Hits        18248    18248           
  Misses       8964     8964           
Impacted Files Coverage Δ
astroquery/astrometry_net/core.py 50.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca7593...4738822. Read the comment docs.

@bsipocz
Copy link

bsipocz commented May 24, 2021

but after thinking more, I don't think we should make this change

no, I don't think we should suppress this warning. Users should do it on their end, or rather get an API key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants