Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty error, This closes #19 #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastianCzoch
Copy link

No description provided.


expect(t, len(responses), 0)

correctResponse := json.Unmarshal([]byte(` `), struct{}{})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json.SyntaxError has only Offset field exported, so this is the easiest way to test this case in current testing flow.

@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage increased (+0.02%) to 96.992% when pulling 9685096 on SebastianCzoch:master into 1775dd4 on keighl:master.

@widmogrod
Copy link

@keighl could you take a look at this PR, this improvement solves also my issues. It would be fantastic to have it merged.

@kevinburke1
Copy link

FYI this fails for me when I run go vet ./... with this error:

./mandrill_test.go:93:35: call of Unmarshal passes non-pointer as second argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants