Ignore restart on a given rollout or deployment #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 51.02% 49.04% -1.98%
==========================================
Files 13 14 +1
Lines 488 526 +38
==========================================
+ Hits 249 258 +9
- Misses 212 241 +29
Partials 27 27 ☔ View full report in Codecov by Sentry. |
main.go
Outdated
| @@ -61,6 +62,7 @@ func main() { | |||
| "Enable leader election for controller manager. "+ | |||
| "Enabling this will ensure there is only one active controller manager.") | |||
| flag.DurationVar(&flagReconcilerTime, "reconciler-time", 10*time.Hour, "The flippy reconciler time.") | |||
| flag.StringVar(&common.IgnoreMetadata, "ignore-metadata", "flippy-ignore", "Annotation (Rollout/Deployment) and Label (Namespace) to be ignored") | |||
There was a problem hiding this comment.
Can this parameter named as flippy-ignore-key?
vrushalijoshi
approved these changes
May 2, 2024
added 3 commits
May 3, 2024 11:23
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a FEATURE REQUEST?:
What happened:
We are adding a filter. If it is present on rollout/deployment/namespace then flippy should not rotate given object
What you expected to happen:
If parameter is provided then
How to reproduce it (as minimally and precisely as possible):
N/A
Environment:
N/A