Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drain-retries option to README #182

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

2rs2ts
Copy link
Contributor

@2rs2ts 2rs2ts commented Jan 8, 2024

It seems like #104 added this option, but since that wasn't yet released, it wasn't added to the README. Now it's part of a release, so, it should be fine to add to the README.

@2rs2ts 2rs2ts requested review from a team as code owners January 8, 2024 19:19
@2rs2ts
Copy link
Contributor Author

2rs2ts commented Jan 8, 2024

I'm new here. I don't know what I am supposed to do about sign-off on a 1-line commit on the README 😅 no one worked with me on it, so who's there to sign off on it? Myself? Guidance would be appreciated.

@ZihanJiang96
Copy link
Member

I'm new here. I don't know what I am supposed to do about sign-off on a 1-line commit on the README 😅 no one worked with me on it, so who's there to sign off on it? Myself? Guidance would be appreciated.

haha just sign it off by yourself
https://github.com/keikoproj/lifecycle-manager/pull/182/checks?check_run_id=20274793558

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (073e30a) 69.78% compared to head (eb39a60) 69.78%.
Report is 1 commits behind head on master.

❗ Current head eb39a60 differs from pull request most recent head 1c82749. Consider uploading reports for the commit 1c82749 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   69.78%   69.78%           
=======================================
  Files          12       12           
  Lines        1314     1314           
=======================================
  Hits          917      917           
  Misses        325      325           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It seems like keikoproj#104 added this option, but since that wasn't yet
released, it wasn't added to the README.  Now it's part of a
release, so, it should be fine to add to the README.

Signed-off-by: 2rs2ts <[email protected]>
@ZihanJiang96 ZihanJiang96 merged commit b7c1641 into keikoproj:master Feb 3, 2024
2 checks passed
@2rs2ts 2rs2ts deleted the patch-1 branch February 20, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants