Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ec2:DescribeLaunchTemplates permission #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bodgit
Copy link

@bodgit bodgit commented Mar 26, 2021

This goes part way to fixing #194

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #200 (1d5ce44) into master (4da0472) will decrease coverage by 0.54%.
The diff coverage is n/a.

❗ Current head 1d5ce44 differs from pull request most recent head 3d7af89. Consider uploading reports for the commit 3d7af89 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   69.48%   68.93%   -0.55%     
==========================================
  Files          12       11       -1     
  Lines        1088      940     -148     
==========================================
- Hits          756      648     -108     
+ Misses        294      260      -34     
+ Partials       38       32       -6     
Flag Coverage Δ
unittests 68.93% <ø> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/rollingupgrade_types.go 66.66% <0.00%> (-31.64%) ⬇️
controllers/rollingupgrade_controller.go 68.62% <0.00%> (-1.17%) ⬇️
controllers/helpers.go 98.41% <0.00%> (ø)
api/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
controllers/common/metrics.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da0472...3d7af89. Read the comment docs.

@eytan-avisror
Copy link
Contributor

Looks like this cannot be rebased, @bodgit can you resend this PR?

Copy link
Collaborator

@shreyas-badiger shreyas-badiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this.

@juniorz
Copy link

juniorz commented Dec 30, 2021

ec2:DescribeLaunchTemplateVersions also seems to be missing.

@tekenstam tekenstam self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants