Early cordon #405
Merged
Early cordon #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sbadiger <[email protected]>
Signed-off-by: sbadiger <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 39.09% 43.75% +4.65%
==========================================
Files 7 7
Lines 931 1104 +173
==========================================
+ Hits 364 483 +119
- Misses 540 575 +35
- Partials 27 46 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Todd Ekenstam <[email protected]> Signed-off-by: sbadiger <[email protected]>
* Process drain-failures at the end Signed-off-by: ssheladiya <[email protected]> Signed-off-by: sbadiger <[email protected]>
Signed-off-by: sbadiger <[email protected]>
Signed-off-by: sbadiger <[email protected]>
Signed-off-by: sbadiger <[email protected]>
Signed-off-by: sbadiger <[email protected]>
Signed-off-by: sbadiger <[email protected]>
Signed-off-by: sbadiger <[email protected]>
vgunapati
reviewed
Nov 29, 2023
Co-authored-by: Venkata Gunapati <[email protected]>
vgunapati
reviewed
Dec 1, 2023
vgunapati
reviewed
Dec 1, 2023
Co-authored-by: Venkata Gunapati <[email protected]>
vgunapati
approved these changes
Dec 5, 2023
ZihanJiang96
reviewed
Dec 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, upgrade-manager supports 2 different strategies:
Eager mode - Eagerly wait for replacement nodes and only then drain & terminate the previous instances.
Lazy mode - Rotate (drain and terminate) the desired number of nodes without waiting for the replacement nodes.
In these two strategies, we cordon only the nodes that are in the current batch (batch size is determined by maxUnavailable mentioned in the RollingUpgrade CR. By default maxUnavailable=1)
While the upgrade is in progress, the remaining older nodes that are not yet considered in the node-rotation batch, might have newer deployments / pods scheduled.
These newly scheduled pods could have yet another restart when the underlying older nodes are considered for rotation.
There is also an added time for draining these nodes with additional new pods.
With the approach in PR, we will cordon all the nodes in the respective IG when a rollingUpgrade CR is being processed. The newer pods will always scheduled on newer nodes when an upgrade is in progress.