Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the PyPi file structure for packages #83

Merged
merged 7 commits into from
May 13, 2024

Conversation

teodora-aleksovska
Copy link

This pull request includes changes to the project's structure and file/folder names.
Please review this PR, but do not merge it until I finish testing the enabler commands. Could you confirm if the project structure is correct now?

@gocemitevski
Copy link
Member

gocemitevski commented Apr 30, 2024

@teodora-aleksovska we need to satisfy of all the requirements from https://packaging.python.org/en/latest/tutorials/packaging-projects/#creating-the-package-files.

packaging_tutorial/
├── LICENSE
├── pyproject.toml
├── README.md
├── src/
│   └── example_package_YOUR_USERNAME_HERE/
│       ├── __init__.py
│       └── example.py
└── tests

Our PyPi.net organization user name - YOUR_USERNAME_HERE is keitaro-inc.

https://pypi.org/user/keitaro-inc/

@gocemitevski
Copy link
Member

gocemitevski commented May 10, 2024

@teodora-aleksovska can't we modify the download_and_make_executable function instead of using urllib? 4ba402d#diff-bf5e4bc39b0290e2e25a951576f0e071d51c4859c3a8ae1a37301acdfdb7884aR72

Also, please use variables for values which get repeated more than once (i.e. bin/helm.tar.gz).

@teodora-aleksovska
Copy link
Author

@teodora-aleksovska can't we modify the download_and_make_executable function instead of using urllib? 4ba402d#diff-bf5e4bc39b0290e2e25a951576f0e071d51c4859c3a8ae1a37301acdfdb7884aR72

Also, please use variables for values which get repeated more than once (i.e. bin/helm.tar.gz).

@gocemitevski please review this modification of download_and_make_executable function: fa29b54

@gocemitevski gocemitevski merged commit d4bb626 into main May 13, 2024
2 checks passed
@gocemitevski gocemitevski deleted the feature-enabler-structure branch May 13, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants