Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of
Resize()
view, when in certain scenarios the subscribers weren't properly updated (either subscribe or unsubscribe). Also Rect API has changed, it is now exclusive of the bottom-right boundary to align with more widely adopted approaches.View Enhancements:
View
functionality by adding aMoveTo
method and refining theResize
method to handle view changes more efficiently inview.go
.view_test.go
to include new test cases forMoveTo
and adjusted existing tests to reflect changes inView
behavior. [1] [2] [3]Rect Enhancements:
Rect
API by modifyingContains
,Intersects
, andSize
methods to be value receivers and added new methods likeIsZero
andDifference
for better rectangle operations inpoint.go
.Within
andWithinRect
methods ofPoint
to utilize the newRect
methods.Dependency Updates:
github.com/kelindar/iostream
to v1.4.0 andgithub.com/stretchr/testify
to v1.9.0 ingo.mod
.