Pylint refactor #851
Merged
Pylint refactor #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves pylint score from 3.71 to 10.00 fixes #2
improves pylint score from 5.83 to 10.00. fixes #7
…actor-unionfind refactor(pylint): unionfind/count_islands.py
…actor-search refactor(pylint): algorithms/search/*.py
Improves pylint score from 5.51 to 9.96. Score is lower than 10 due to duplication between maximum_flow_bfs.py and maximum_flow_dfs.py. However, due to the educational nature of this repo, keeping it as is will probably be benefitial as it reduces complexity while reading (having to jump between files). fixes #9
a reason that lint score isn't 10.00 is that the module is called dp, which in turn makes pylint raise invalid name for all files in dp. I leave that as it is, since I don't want to mess with the current folder structure. fixes #3
…factor-dp refactor(pylint): algorithms/dp/*.py
…factor-streaming-#5 refactor (pylint): algorithms/streaming/*.py
Fix: pylint is above 8 for tree
Finished improving pylint score for maths folder. fixes: #4
…factor-maths refactor (pylint): algorithms/maths/
…factor-graph refactor(pylint): algorithms/graph/*.py
…ap-16 Fix: Fixed lint error, lint value now above 8
|
Thanks for picking this up. Much needed and had been pending for a while. |
|
@ankit167 Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started refactoring the codebase in order to improve the pylint score (see #761). The work is not entirely done, but so far the following modules have been updated to reach a score of at least 8:
graphunionfindmathsdpheapsearchstreamingmltreeThe work included the following refactors: