Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for retaining existing album gain via CLI argument #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maszaa
Copy link
Contributor

@maszaa maszaa commented May 22, 2020

Via -p/--preserve-album-gain CLI argument

@kepstin
Copy link
Owner

kepstin commented May 26, 2020

Hi @maszaa - thanks for the PR! I have a couple requests:

Please split out the commit for using virtualenv/pip into a separate PR, since it's not related to the album gain issue.

I'd like the option name to be more positive, and better describe what happens. Instead of "ignore album gain", I think "preserve album gain" would be better. This is because the option should keep any album gain tags that are already present without modifying them.

@maszaa maszaa force-pushed the feature/allow-missmatching-album-gain branch from 529556c to dedbb39 Compare May 28, 2020 16:43
@maszaa
Copy link
Contributor Author

maszaa commented May 28, 2020

Good points, I updated the PR

@maszaa maszaa force-pushed the feature/allow-missmatching-album-gain branch from dedbb39 to 4efc230 Compare May 28, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants